Modify function definitions #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eddasol
added
improvement
andchiind
reviewed
Nov 24, 2023
frontend/src/components/Displays/MissionDisplays/MissionStatusDisplay.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Pages/MissionPage/TaskOverview/TaskStatusDisplay.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Pages/MissionPage/VideoStream/VideoPlayerOvenPlayer.tsx
Outdated
Show resolved
Hide resolved
andchiind
reviewed
Nov 27, 2023
frontend/src/components/Pages/MissionPage/MissionHeader/MissionHeader.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Pages/MissionPage/VideoStream/VideoStreamWindow.tsx
Outdated
Show resolved
Hide resolved
andchiind
approved these changes
Nov 29, 2023
| @@ -51,9 +51,7 @@ export function RobotStatusSection() { | |||
| }, [enabledRobots, installationCode, switchSafeZoneStatus]) | |||
|
|
|||
| const getRobotDisplay = () => { | |||
There was a problem hiding this comment.
Does this need to be a function?
Suggested change
| const getRobotDisplay = () => { | |
| const robotDisplay = robots.map((robot) => <RobotStatusCard key={robot.id} robot={robot} />) |
There was a problem hiding this comment.
In general if a local function has no arguments (or if the argument values never change) and no side effects, then it can be safely made into a variable
There was a problem hiding this comment.
There are several like this so I suggest fixing them in separate PR
| @@ -67,7 +67,7 @@ export function MissionMapView({ mission }: MissionProps) { | |||
| } | |||
|
|
|||
| const findCurrentTaskOrder = useCallback(() => { | |||
| mission.tasks.forEach(function (task) { | |||
| mission.tasks.forEach((task) => { | |||
| if (task.status === TaskStatus.InProgress || task.status === TaskStatus.Paused) { | |||
| setCurrentTaskOrder(task.taskOrder) | |||
There was a problem hiding this comment.
Unrelated to your PR, but this isn't necessarily safe. Sorry you can ignore this comment, this is moreso a reminder to myself :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.