Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a cronjob functionality intended for InspectionReportGeneration #1218

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Make a cronjob functionality intended for InspectionReportGeneration #1218

merged 6 commits into from
Nov 27, 2023

Conversation

UsamaEquinorAFK
Copy link
Contributor

@UsamaEquinorAFK UsamaEquinorAFK commented Nov 23, 2023 •
edited
Loading

This pull request implements the service responsible for cronjob functionality described here #1102

@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@UsamaEquinorAFK UsamaEquinorAFK changed the title Inspecti Make a cronjob functionality by use of hosted background service which fetches all the inspections in last 24 hours and is called by an EventHandler Nov 23, 2023
@UsamaEquinorAFK UsamaEquinorAFK mentioned this pull request Nov 23, 2023
Closed
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the crj-eventhandler branch 2 times, most recently from f381328 to a4827d1 Compare November 23, 2023 23:12
@UsamaEquinorAFK UsamaEquinorAFK mentioned this pull request Nov 23, 2023
Closed
@UsamaEquinorAFK UsamaEquinorAFK self-assigned this Nov 23, 2023
Christdej
Christdej requested changes Nov 24, 2023
View reviewed changes
backend/api/Services/InspectionFindingsService.cs Outdated Show resolved Hide resolved
backend/api/Services/InspectionFindingsService.cs Outdated Show resolved Hide resolved
backend/api/Program.cs Outdated Show resolved Hide resolved
backend/api/Database/Context/FlotillaDbContext.cs Outdated Show resolved Hide resolved
backend/api/Services/InspectionFindingsService.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Nov 24, 2023
eivindsjovold
eivindsjovold previously requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash some commits

@UsamaEquinorAFK UsamaEquinorAFK dismissed eivindsjovold’s stale review November 24, 2023 08:36

Will be refactored and squashed quite a bit I think once I have addressed other comments on functionailty. Dismissing since you requested changes and dont want this to be blocker later on while merging. This should be a suggested change.

@UsamaEquinorAFK UsamaEquinorAFK force-pushed the crj-eventhandler branch 6 times, most recently from 42513fd to 7ecf162 Compare November 24, 2023 12:13
@UsamaEquinorAFK UsamaEquinorAFK force-pushed the crj-eventhandler branch 4 times, most recently from d1e3f3c to f8cfaf1 Compare November 24, 2023 13:57
@UsamaEquinorAFK UsamaEquinorAFK changed the title Make a cronjob functionality by use of hosted background service which fetches all the inspections in last 24 hours and is called by an EventHandler Make a cronjob functionality inteded for InspectionReportGeneration Nov 24, 2023
@UsamaEquinorAFK UsamaEquinorAFK changed the title Make a cronjob functionality inteded for InspectionReportGeneration Make a cronjob functionality intended for InspectionReportGeneration Nov 24, 2023
Christdej
Christdej approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UsamaEquinorAFK
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@UsamaEquinorAFK UsamaEquinorAFK merged commit 3b93684 into equinor:main Nov 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddasol Eddasol Eddasol left review comments

@Christdej Christdej Christdej approved these changes

@eivindsjovold eivindsjovold eivindsjovold left review comments

Assignees

@UsamaEquinorAFK UsamaEquinorAFK

Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@UsamaEquinorAFK @Eddasol @Christdej @eivindsjovold @MuhammadUsama-afk-equinor