-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for min pressure in robot when starting missions #1280
Conversation
0a5e546
to
0b80199
Compare
🔔 Changes in database folder detected 🔔 |
845d16e
to
a54f529
Compare
a54f529
to
581e1e3
Compare
81e3ab6
to
fd5ac23
Compare
dabe1b9
to
30481e5
Compare
frontend/src/components/Pages/InspectionPage/ScheduleMissionDialogs.tsx
Outdated
Show resolved
Hide resolved
291cfde
to
a7e1f28
Compare
This works if scheduling echo missions but not if scheduling missions trough inspection page or re-running a mission |
9598d6f
to
e0853e2
Compare
...nts/Pages/FrontPage/MissionOverview/ScheduleMissionDialog/SelectMissionsToScheduleDialog.tsx
Outdated
Show resolved
Hide resolved
It prevents the user from scheduling the mission when the pressure is too low, but queued missions will still begin. Should there be some check on that as well? |
This would involve having a check in the queue event handler which cancels missions if the pressure is too low. In effect it would cancel all missions in the queue and then send an error to the frontend for each mission. It is possible but I think we may need to have further UX discussions before implementing this. The scope of this PR was to provide user feedback when scheduling missions. |
a964565
to
2b59854
Compare
2b59854
to
27a3bcc
Compare
27a3bcc
to
ab13f92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
ab13f92
to
43fc92d
Compare
Closes #1019
There might be some smaller conflicts with #1279 to be merged, since I rewrote the update robot controller in order to implement this. This will need to use the new update service functions in that PR, if their interface changes.