Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for min pressure in robot when starting missions #1280

Merged
merged 10 commits into from
Jan 30, 2024

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Dec 20, 2023

Closes #1019

There might be some smaller conflicts with #1279 to be merged, since I rewrote the update robot controller in order to implement this. This will need to use the new update service functions in that PR, if their interface changes.

@andchiind andchiind added feature New feature or request backend Backend related functionality database-change Will require migration labels Dec 20, 2023
@andchiind andchiind self-assigned this Dec 20, 2023
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@andchiind andchiind force-pushed the 1019-check-pressure branch 2 times, most recently from 845d16e to a54f529 Compare December 27, 2023 14:27
@andchiind
Copy link
Contributor Author

Here is what it looks like in the frontend:
image

@andchiind andchiind marked this pull request as ready for review December 28, 2023 10:45
@andchiind andchiind force-pushed the 1019-check-pressure branch 9 times, most recently from 81e3ab6 to fd5ac23 Compare January 4, 2024 08:24
@andchiind andchiind force-pushed the 1019-check-pressure branch from dabe1b9 to 30481e5 Compare January 4, 2024 14:47
@andchiind andchiind force-pushed the 1019-check-pressure branch 3 times, most recently from 291cfde to a7e1f28 Compare January 9, 2024 14:56
@Eddasol
Copy link
Contributor

Eddasol commented Jan 12, 2024

This works if scheduling echo missions but not if scheduling missions trough inspection page or re-running a mission

@andchiind andchiind force-pushed the 1019-check-pressure branch 2 times, most recently from 9598d6f to e0853e2 Compare January 12, 2024 12:47
@Eddasol
Copy link
Contributor

Eddasol commented Jan 18, 2024

It prevents the user from scheduling the mission when the pressure is too low, but queued missions will still begin. Should there be some check on that as well?

@andchiind
Copy link
Contributor Author

It prevents the user from scheduling the mission when the pressure is too low, but queued missions will still begin. Should there be some check on that as well?

This would involve having a check in the queue event handler which cancels missions if the pressure is too low. In effect it would cancel all missions in the queue and then send an error to the frontend for each mission. It is possible but I think we may need to have further UX discussions before implementing this. The scope of this PR was to provide user feedback when scheduling missions.

@andchiind andchiind force-pushed the 1019-check-pressure branch 5 times, most recently from a964565 to 2b59854 Compare January 25, 2024 13:56
@andchiind andchiind requested a review from Eddasol January 29, 2024 13:44
@mrica-equinor mrica-equinor added the frontend Frontend related functionality label Jan 30, 2024
@andchiind andchiind force-pushed the 1019-check-pressure branch from 2b59854 to 27a3bcc Compare January 30, 2024 09:30
@andchiind andchiind force-pushed the 1019-check-pressure branch 2 times, most recently from 27a3bcc to ab13f92 Compare January 30, 2024 13:05
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andchiind andchiind force-pushed the 1019-check-pressure branch from ab13f92 to 43fc92d Compare January 30, 2024 13:07
@andchiind andchiind merged commit 76f29d1 into equinor:main Jan 30, 2024
11 checks passed
@andchiind andchiind deleted the 1019-check-pressure branch January 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality database-change Will require migration feature New feature or request frontend Frontend related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate battery and pressure levels before starting missions
4 participants