Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alert for failure to send robot to safe zone #1294

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Add alert for failure to send robot to safe zone #1294

merged 3 commits into from
Jan 2, 2024

Conversation

andchiind
Copy link
Contributor

Closes #1291

@andchiind andchiind added backend Backend related functionality improvement Improvement to existing functionality frontend Frontend related functionality labels Dec 27, 2023
@andchiind andchiind self-assigned this Dec 27, 2023
@andchiind
Copy link
Contributor Author

andchiind commented Dec 27, 2023 •
edited
Loading

We might want to address this before merging: #1291 (comment)

Although I think a discussion is needed. It could be good to just merge it now and address it at a later time.

@andchiind andchiind force-pushed the 1291-return-home branch 2 times, most recently from 90da061 to 31e8689 Compare December 28, 2023 11:51
@andchiind andchiind marked this pull request as ready for review December 28, 2023 12:05
UsamaEquinorAFK
UsamaEquinorAFK approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@UsamaEquinorAFK UsamaEquinorAFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test. Looks clean and good.

@andchiind andchiind force-pushed the 1291-return-home branch 2 times, most recently from 22ab935 to 310128f Compare December 29, 2023 10:58
@andchiind andchiind marked this pull request as draft January 2, 2024 07:54
@andchiind andchiind marked this pull request as ready for review January 2, 2024 08:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@andchiind andchiind merged commit 34a7cd4 into equinor:main Jan 2, 2024
11 checks passed
@andchiind andchiind deleted the 1291-return-home branch January 2, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UsamaEquinorAFK UsamaEquinorAFK UsamaEquinorAFK approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The frontend should receive a warning the robot could not be returned home
2 participants
@andchiind @UsamaEquinorAFK