Change the title of inspection card #1325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,10 +70,8 @@ const DeckCard = ({ deckData, deckName, setSelectedDeck, selectedDeck, handleSch | |||
| </StyledDict.Content> | |||
| ))} | |||
| </StyledDict.TopDeckText> | |||
| {deckData.areas && <Typography variant={'body_short'}>{formattedAreaNames}</Typography>} | |||
There was a problem hiding this comment.
Can you try to explain why we no longer need to check for deck.areas and deck.inspections?
There was a problem hiding this comment.
They cannot be undefined so it will always be true. Can alternatively check if its an empty list but that will not be triggered by checking if deckData.areas is true
There was a problem hiding this comment.
Have you tested when deck.areas is empty? I remember having some issues with something similar, not sure if it was the same, but if you have tested it with empy values and it's good then I think it can be merged
There was a problem hiding this comment.
I think I hard-coded it to [] and the text still showed. Its been a few days, so don't fully remember
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.