Refactor ongoing mission page for iphone use #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
requested review from
andchiind,
oysand,
Eddasol and
UsamaEquinorAFK
|
I would recommend only testing this after PR #1326 is merged |
mrica-equinor
added
improvement
mrica-equinor
force-pushed
the
ongoing-mission-page-iphone
branch
from
d27eeaa to
c77fad6
Compare
|
Would rename PR and commit to "Refactor mission page for iphone use" instead of "Refactor ongoing mission page for iphone use " since its not just for ongoing missions but all mission runs |
Eddasol
reviewed
Jan 12, 2024
frontend/src/components/Pages/MissionPage/MissionHeader/MissionHeader.tsx
Show resolved
Hide resolved
Eddasol
reviewed
Jan 12, 2024
| @@ -7,8 +7,12 @@ import { tokens } from '@equinor/eds-tokens' | |||
| import { getColorsFromTaskStatus } from 'utils/MarkerStyles' | |||
|
|
|||
| const StyledTable = styled(Table)` | |||
| grid-column: 1/ -1; | |||
| font: equinor; | |||
| display: grid; | |||
There was a problem hiding this comment.
Content of table doesn't align with table header
Eddasol
reviewed
Jan 12, 2024
frontend/src/components/Pages/MissionPage/MissionHeader/MissionHeader.tsx
Outdated
Show resolved
Hide resolved
Eddasol
reviewed
Jan 12, 2024
frontend/src/components/Pages/MissionPage/TaskOverview/TaskTable.tsx
Outdated
Show resolved
Hide resolved
Eddasol
reviewed
Jan 12, 2024
frontend/src/components/Pages/MissionPage/MissionHeader/MissionHeader.tsx
Outdated
Show resolved
Hide resolved
mrica-equinor
force-pushed
the
ongoing-mission-page-iphone
branch
4 times, most recently
from
25530b9 to
4caec72
Compare
mrica-equinor
force-pushed
the
ongoing-mission-page-iphone
branch
from
4caec72 to
94969ff
Compare
mrica-equinor
force-pushed
the
ongoing-mission-page-iphone
branch
from
94969ff to
96aa4f2
Compare
Eddasol
reviewed
Jan 12, 2024
Comment on lines
+200
to
+206
| {!isMissionCompleted && HeaderText(translatedBatteryLevel, `${mission.robot.batteryLevel}%`)} | ||
| {!isMissionCompleted && | ||
| mission.robot.pressureLevel && | ||
| HeaderText( | ||
| translatedPressureLevel, | ||
| `${Math.round(mission.robot.pressureLevel * barToMillibar)}mBar` | ||
| )} |
There was a problem hiding this comment.
Alignment is off on completed missions
Eddasol
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #900