Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing pressure on new robots #1329

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Fix missing pressure on new robots #1329

merged 3 commits into from
Jan 15, 2024

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 12, 2024 •
edited
Loading

This is a fix for:

  • If pressure is null it will never get updated and will stay null
  • If upperPressureWarningThreshold or lowerPressureWarningThreshold is null, the pressure icon will show but the pressure value is missing

@Eddasol Eddasol added bug Something isn't working backend Backend related functionality labels Jan 12, 2024
@Eddasol Eddasol self-assigned this Jan 12, 2024
@equinor equinor deleted a comment from github-actions bot Jan 12, 2024
@Eddasol Eddasol requested a review from aeshub January 12, 2024 08:43
@Eddasol Eddasol force-pushed the missing-pressure branch 4 times, most recently from e37b17b to ca67cd8 Compare January 12, 2024 12:53
@Eddasol Eddasol force-pushed the missing-pressure branch 3 times, most recently from d0adcfa to 69be89b Compare January 12, 2024 14:40
@Eddasol Eddasol requested a review from andchiind January 12, 2024 14:45
andchiind
andchiind approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol added the frontend Frontend related functionality label Jan 15, 2024
@Eddasol Eddasol merged commit 1bc3601 into equinor:main Jan 15, 2024
10 checks passed
@Eddasol Eddasol deleted the missing-pressure branch January 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

@aeshub aeshub Awaiting requested review from aeshub

Assignees

@Eddasol Eddasol

Labels
backend Backend related functionality bug Something isn't working frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @andchiind