Fix localization failure bug and refactor #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oysand
force-pushed
the
fix-localization-failure-should-cancel-mission
branch
from
26598f9 to
8bebb1c
Compare
oysand
force-pushed
the
fix-localization-failure-should-cancel-mission
branch
from
fa26bdb to
3e63e50
Compare
oysand
force-pushed
the
fix-localization-failure-should-cancel-mission
branch
7 times, most recently
from
ff4a7a1 to
6eeb63d
Compare
Afonso-2403
force-pushed
the
fix-localization-failure-should-cancel-mission
branch
2 times, most recently
from
be65564 to
656ce98
Compare
Afonso-2403
force-pushed
the
fix-localization-failure-should-cancel-mission
branch
3 times, most recently
from
5ea87bd to
2bc0ede
Compare
tsundvoll
reviewed
Mar 1, 2024
tsundvoll
reviewed
Mar 1, 2024
|
See if this needs to be addressed #1446 |
oysand
force-pushed
the
fix-localization-failure-should-cancel-mission
branch
from
683dae4 to
2377c29
Compare
Added a fix to the refactor commit: Refactor OnRobotAvailable and localization feature |
Large parts of the OnRobotAvailable and localization feature have been moved into the StartNextMissionRunIfSystemIsAvailable
When a return home mission is created the OnMissionRunCreated event should not be fired
Due to OnRobotAvailable and OnMissionCompleted being triggered at different times a return to home mission could be scheduled twice without this check
Move it to the signalRService and made it public so that it can be used in other places
oysand
force-pushed
the
fix-localization-failure-should-cancel-mission
branch
from
2377c29 to
3a60e78
Compare
tsundvoll
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fix: Current area is set based on result from localization mission.
Other changes: