Assure inspection mission list is unique for each installation #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrica-equinor
force-pushed
the
fix-set-mission-definitions
branch
from
e190095 to
6d51502
Compare
andchiind
reviewed
Feb 12, 2024
Comment on lines
+35
to
+37
| registerEvent(SignalREventLabels.missionDefinitionUpdated, (username: string, message: string) => {}) | ||
| registerEvent(SignalREventLabels.missionDefinitionCreated, (username: string, message: string) => {}) | ||
| registerEvent(SignalREventLabels.missionDefinitionDeleted, (username: string, message: string) => {}) |
There was a problem hiding this comment.
I'm not quite sure why we ignore these events in this commit? If we want to ignore them is it also not easiest to not register the event handler?
|
Closing PR in favor of different solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.