Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of hooks error #1964

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix order of hooks error #1964

merged 1 commit into from
Jan 17, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 17, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol self-assigned this Jan 17, 2025
@Eddasol Eddasol added bug Something isn't working frontend Frontend related functionality labels Jan 17, 2025
@Eddasol Eddasol requested a review from andchiind January 17, 2025 11:22
andchiind
andchiind approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol merged commit 8d869ef into equinor:main Jan 17, 2025
12 checks passed
@Eddasol Eddasol deleted the fix-hook branch January 17, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@Eddasol Eddasol

Labels
bug Something isn't working frontend Frontend related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @andchiind