Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspect return to home #1988

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Inspect return to home #1988

merged 1 commit into from
Jan 28, 2025

Conversation

mrica-equinor
Copy link
Contributor

@mrica-equinor mrica-equinor commented Jan 28, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@mrica-equinor mrica-equinor force-pushed the inspect-return-to-home branch 6 times, most recently from 4a441b6 to ebbf2b7 Compare January 28, 2025 12:44
@mrica-equinor mrica-equinor force-pushed the inspect-return-to-home branch from ebbf2b7 to 0e02b4d Compare January 28, 2025 12:45
oysand
oysand approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrica-equinor mrica-equinor merged commit e6d04e7 into equinor:main Jan 28, 2025
12 checks passed
andchiind
andchiind reviewed Jan 28, 2025
View reviewed changes
backend/api/Services/MissionSchedulingService.cs
{
await robotService.UpdateCurrentInspectionArea(
robot.Id,
missionRun.InspectionArea.Id
missionRun.InspectionArea!.Id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we ensure that this is not null?

backend/api/Services/ReturnToHomeService.cs
logger.LogInformation(
"Scheduled a mission for the robot {RobotName} to return to home location on inspection area {InspectionAreaName}",
"Scheduled Return to Home mission for robot {RobotName} on Inspection Area {InspectionAreaName}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Scheduled Return to Home mission for robot {RobotName} on Inspection Area {InspectionAreaName}",
"Scheduled Return Home mission for robot {RobotName} on Inspection Area {InspectionAreaName}",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind left review comments

@oysand oysand oysand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrica-equinor @andchiind @oysand