Handle empty media stream config

equinor · Feb 3, 2025 · 53c7f4d · 53c7f4d
1 parent 6d92063
commit 53c7f4d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/isar/apis/api.py b/src/isar/apis/api.py
@@ -301,6 +301,14 @@ def _create_media_control_router(self) -> APIRouter:
             methods=["GET"],
             dependencies=[authentication_dependency],
             summary="Generates a media stream connection config",
+            responses={
+                HTTPStatus.OK.value: {
+                    "description": "Media stream was successfully generated",
+                },
+                HTTPStatus.NO_CONTENT.value: {
+                    "description": "Robot has no media config",
+                },
+            },
         )
 
         return router

diff --git a/src/isar/apis/robot_control/robot_controller.py b/src/isar/apis/robot_control/robot_controller.py
@@ -5,6 +5,7 @@
 from isar.apis.models.models import RobotInfoResponse
 from isar.config.settings import robot_settings, settings
 from isar.services.utilities.robot_utilities import RobotUtilities
+from fastapi import HTTPException
 
 
 class RobotController:
@@ -17,7 +18,13 @@ def __init__(
         self.logger = logging.getLogger("api")
 
     def generate_media_config(self):
-        return self.robot_utilities.generate_media_config()
+        media_config = self.robot_utilities.generate_media_config()
+        if media_config is None:
+            raise HTTPException(
+                status_code=204,
+                detail="Robot has no media config",
+            )
+        return media_config
 
     def get_info(self):
         return RobotInfoResponse(