Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vega EOS modell(helmholtz free energy) for helium #1278

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

victorigi99
Copy link
Contributor

No description provided.

@victorigi99 victorigi99 requested a review from EvenSol as a code owner February 11, 2025 13:17
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 120 lines in your changes missing coverage. Please review.

Project coverage is 41.80%. Comparing base (d7cf0b1) to head (2c9519f).

Files with missing lines Patch % Lines
.../main/java/neqsim/thermo/util/Vega/NeqSimVega.java 0.00% 65 Missing ⚠️
src/main/java/neqsim/thermo/util/Vega/Vega.java 79.01% 40 Missing and 11 partials ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1278      +/-   ##
============================================
+ Coverage     41.71%   41.80%   +0.08%     
- Complexity     6170     6189      +19     
============================================
  Files           729      731       +2     
  Lines         69423    69735     +312     
  Branches       8327     8359      +32     
============================================
+ Hits          28962    29154     +192     
- Misses        38689    38798     +109     
- Partials       1772     1783      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil
Copy link
Collaborator

please run
mvn javadoc:fix and commit the changes before merge

@EvenSol EvenSol merged commit e610d14 into equinor:master Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants