Potential fix for code scanning alert no. 2: Clear-text logging of sensitive information #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of sensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Einar Wigum Arbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/equinor/template-fastapi-react/security/code-scanning/2
To fix this problem, we should avoid directly logging the value of
config.OAUTH_WELL_KNOWN. Instead, we can log a general error message without including the potentially sensitive configuration value. This ensures attackers cannot retrieve configuration details from log files, and we maintain useful error logging for debugging.Hence, in
get_JWK_clienton line 27, we should change:to something like:
No new imports or methods are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.