ci: remove CodeQL workflow in favour of GHAS default setup#555
Merged
Conversation
einarwar
force-pushed
the
chore/remove-codeql-workflow
branch
from
5c2a889 to
2e41536
Compare
The workflow at .github/workflows/codeql.yaml was the stock 'advanced setup' template with no customisation (no custom query suite, no config file, no path filters, no manual build steps). It produces the same analysis coverage as GHAS default setup for JavaScript/TypeScript and Python, but requires us to maintain the workflow, pin action SHAs and follow major-version bumps of github/codeql-action. Switching to default setup removes that maintenance burden. Activation steps are listed in the PR description.
einarwar
force-pushed
the
chore/remove-codeql-workflow
branch
from
2e41536 to
0e99bbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
.github/workflows/codeql.yamland switches CodeQL analysis to GHAS default setup, managed entirely from the repository settings UI.The deleted workflow was the stock advanced-setup template with no customisation — no custom query suite, no config file, no path filters, no manual build steps — so default setup produces equivalent analysis coverage for JavaScript/TypeScript and Python with no in-repo file to maintain.
Before merging: enable default setup in the repo
Default setup must be turned on before this PR is merged, otherwise code scanning will stop producing results in the gap between merge and activation.
Default(matches what the deleted workflow ran). Switch toExtendedonly if you want the additional lower-severity / quality queries.After the first run completes successfully, merge this PR.
What is lost
paths/paths-ignore, custom queries, or a different trigger schedule.If any of those become desirable later, default setup can be replaced by re-introducing an advanced-setup workflow.