fix(ci): remove non-existent web image from rollback matrix#556
Open
einarwar wants to merge 1 commit into
Open
fix(ci): remove non-existent web image from rollback matrix#556einarwar wants to merge 1 commit into
einarwar wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Removes a stale web image entry from the rollback workflow matrix. Since publish-image.yaml only publishes api and nginx images (the frontend is bundled into the nginx image), attempting a rollback for web would fail with manifest unknown.
Changes:
- Drop
ghcr.io/equinor/template-fastapi-react/webfrom the rollback matrix in.github/workflows/rollback.yaml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The publish-image workflow no longer builds a 'web' image (the frontend is bundled into the 'nginx' image), so attempting to rollback the 'web' image would fail with a manifest-not-found error.
einarwar
force-pushed
the
fix/rollback-remove-stale-web-image
branch
from
3040d07 to
750d11c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish-imageworkflow no longer builds a standalonewebimage — the frontend is bundled into thenginximage. Attempting a rollback would therefore fail with amanifest unknownerror on thewebmatrix entry.This PR removes
ghcr.io/equinor/template-fastapi-react/webfrom the rollback matrix so only the images that are actually published (api,nginx) are tagged.