chore(ci): build images with docker/build-push-action#564
Open
einarwar wants to merge 1 commit into
Open
Conversation
Replace raw `docker pull` + `docker build` + (where applicable) tag/push loops with the canonical `docker/setup-buildx-action` + `docker/build-push-action` pair. publish-image.yaml: - nginx and api build jobs now use build-push-action with multi-tag `tags` lists computed from the comma-separated `image-tags` input, `cache-from: type=registry,ref=<image>:latest`, and `cache-to: type=inline` so subsequent builds keep getting registry cache hits without an explicit `docker pull` step. - Build args / target / context are now declarative. tests.yaml: - api-integration-tests and (disabled) web-tests build steps now use build-push-action with `load: true, push: false` so the image is available locally for the subsequent `docker compose run` step. No behavior change to the published tags (same list, same registry). The `docker compose` test invocations are unchanged. Stacked on top of #563.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace raw
docker pull+docker build+ (where applicable) tag/push loops with the canonicaldocker/setup-buildx-action+docker/build-push-actionpair. Follow-up to #563.publish-image.yamlnginxandapibuild jobs now usebuild-push-actionwith:tagslist computed from the comma-separatedimage-tagsinput,cache-from: type=registry,ref=<image>:latest,cache-to: type=inlineso subsequent builds keep getting registry cache hits without an explicit pre-pull step.target,context,build-argsare now declarative.Publishsteps are gone —build-push-actionpushes all tags directly.tests.yamlapi-integration-testsand (disabled)web-testsbuild steps usebuild-push-actionwithload: true, push: false, so the image is available to the daemon for the subsequentdocker compose runstep.Notes
docker composetest invocations are unchanged.