Replacing ApiStateWrapper and ApiStatesWrapper with QueryStateWrapper #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace state wrappers with a single renamed wrapper which handles both single query and list of queries as prop. For list of queries, it is possible to configure when to display error state: all queries has error, or at least one query has error.
- Add error if every vector list query fails - Allow update of vectorSelectorData even if queries fail, only await fetching state.
rubenthoms
approved these changes
Dec 21, 2023
frontend/src/lib/components/QueryStateWrapper/queryStateWrapper.tsx
Outdated
Show resolved
Hide resolved
frontend/src/lib/components/QueryStateWrapper/queryStateWrapper.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace state wrappers
ApiStateWrapperandApiStatesWrapperwith a single renamed wrapper handling both single query and list of queries as prop.For list of queries, it is possible to configure when to display error state:
1, When all queries has error
2. When at least one query has error.
Closes: #417
Closes: #447