Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted use of BaseComponent and always forwarding ref to it #867

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

rubenthoms
Copy link
Collaborator

No description provided.

@rubenthoms rubenthoms added enhancement New feature or request refactoring labels Feb 7, 2025
@rubenthoms rubenthoms requested a review from Anders2303 February 7, 2025 11:57
@rubenthoms rubenthoms self-assigned this Feb 7, 2025
Copy link
Collaborator

@Anders2303 Anders2303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two places where class-names needs to be fixed, otherwise good to merge 👍

frontend/src/lib/components/Input/input.tsx Outdated Show resolved Hide resolved
frontend/src/lib/components/Input/input.tsx Outdated Show resolved Hide resolved
frontend/src/lib/components/Input/input.tsx Show resolved Hide resolved
Copy link
Collaborator

@Anders2303 Anders2303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rubenthoms rubenthoms merged commit afccefb into equinor:main Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants