-
Notifications
You must be signed in to change notification settings - Fork 151
Add support for DurationInTraffic #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeterDavidson
wants to merge
5
commits into
ericnewton76:master
Choose a base branch
from
PeterDavidson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8897005
Update DirectionLeg.cs
PeterDavidson 2b7287e
Fix the naming of DurationInTraffic
PeterDavidson 67dd1d5
Added in TrafficModel to allow pessimistic and optimistic times to be…
1d3a8e1
Modify the project to remove Net Framework 461 support and move to Ne…
2849a4c
Removed some unused using statements
PeterDavidson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Text; | ||
|
||
namespace Google.Maps { | ||
/// <summary> | ||
/// Specifies the assumptions to use when calculating time in traffic. This setting affects the value returned in the duration_in_traffic field in the response, | ||
/// which contains the predicted time in traffic based on historical averages. The traffic_model parameter may only be specified for driving directions where | ||
/// the request includes a departure_time, and only if the request includes an API key or a Google Maps Platform Premium Plan client ID. | ||
/// </summary> | ||
/// <see href="http://code.google.com/apis/maps/documentation/directions/#traffic_model"/> | ||
public enum TrafficModel { | ||
/// <summary> | ||
/// (default) indicates that the returned duration_in_traffic should be the best estimate of travel time given what is known about both historical | ||
/// traffic conditions and live traffic. Live traffic becomes more important the closer the departure_time is to now. | ||
/// </summary> | ||
best_guess, | ||
|
||
/// <summary> | ||
/// indicates that the returned duration_in_traffic should be longer than the actual travel time on most days, though occasional days with particularly bad traffic conditions may exceed this value | ||
/// </summary> | ||
pessimistic, | ||
|
||
/// <summary> | ||
/// indicates that the returned duration_in_traffic should be shorter than the actual travel time on most days, though occasional days with particularly good traffic conditions may be faster than this value. | ||
/// </summary> | ||
optimistic, | ||
|
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately this change makes it much harder to approve the pull request. I would consider changing the targetframework to be considered out of scope of adding traffic_model to the request.