Work out why SQL tests are 3x slower than others

[wokket]

No description provided.

[erikbra]

I think it is due to startup time. SQL Server is painfully slow to actually be ready to accept connections compared to the other ones. But there might be something else as well, of course

[wokket]

Filling in some info here:

While SQL is slow to start, it's not drastically slower than MySql on my machine, and the startup is only once per run which doesn't explain the speed of the individual tests.

Started MariaDB Server docker container (2636ms): grate-mariadb-vxpoisstit
Listening on port: 49318
Waiting until server is ready
.
.
.
...ready (6185ms).
  Passed EnsureUserTokensAreReplaced [392 ms]
Removed MariaDB Server docker container (1730ms): grate-mariadb-vxpoisstit

Started PostgreSQL docker container (1749ms): grate-postgresql-zipiypznee
Listening on port: 49319
Waiting until server is ready
.
...ready (2355ms).
  Passed EnsureUserTokensAreReplaced [376 ms]
Removed PostgreSQL docker container (1434ms): grate-postgresql-zipiypznee

Started SQL server docker container (1792ms): grate-sqlserver-bbdmgconou
Listening on port: 49320
Waiting until server is ready
.
.
.
...ready (8547ms).
  Passed EnsureUserTokensAreReplaced [6 s]
Removed SQL server docker container (6092ms): grate-sqlserver-bbdmgconou

I re-pointed my sql unit tests at a local SQL instance (not docker) and it's still much slower than the other DB's so def something weird going on.

I'll keep digging...

[wokket]

It's the Dbase create:

Started MariaDB Server docker container (1706ms): grate-mariadb-lefikztrth
Listening on port: 49343
Waiting until server is ready
.
.
.
.
...ready (8191ms).
Conns init: 0ms
DB Create: 55ms
Grate structures init: 97ms
Got DB Versions: 42ms

  Passed EnsureUserTokensAreReplaced [378 ms]
Removed MariaDB Server docker container (1863ms): grate-mariadb-lefikztrth
Started PostgreSQL docker container (2266ms): grate-postgresql-rcadsovvyp
Listening on port: 49344
Waiting until server is ready
.
...ready (2355ms).
Conns init: 0ms
DB Create: 306ms
Grate structures init: 61ms
Got DB Versions: 12ms

  Passed EnsureUserTokensAreReplaced [412 ms]
Removed PostgreSQL docker container (1435ms): grate-postgresql-rcadsovvyp
Started SQL server docker container (1672ms): grate-sqlserver-khnmhqxten
Listening on port: 49345
Waiting until server is ready
.
.
.
...ready (6223ms).
Conns init: 0ms
DB Create: 5578ms
Grate structures init: 101ms
Got DB Versions: 28ms

[erikbra]

The whole issue was apparently connection pooling. I don't know exactly, but we use a lot of different connection string (multiple databases), so we get one connection pool per connection, and (not very surprisingly), there seems to be quite a lot of overhead creating a connection pool, at least when we only use each pool a small amount of time, and then move on.