Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #22: Solved slow SQL Server tests #157

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Conversation

erikbra
Copy link
Owner

@erikbra erikbra commented Dec 17, 2021

* Turned OFF connection pooling on SQL Server connection string for tests
  - Found several discussions on this, e.g. dotnet/SqlClient#601
  - Tried turning off pooling, and it solved the problem...
* Upgraded SQL server docker image used in test from 2017-latest to
  latest (2019 at the time) - didn't make any difference, just to stay
  current.
@erikbra erikbra linked an issue Dec 17, 2021 that may be closed by this pull request
@erikbra erikbra self-assigned this Dec 17, 2021
@erikbra erikbra added the bug Something isn't working label Dec 17, 2021
@erikbra erikbra merged commit 2aac74a into main Dec 17, 2021
@erikbra erikbra deleted the chore/22-sqlserver-slow-tests branch December 17, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Work out why SQL tests are 3x slower than others
1 participant