Update activesupport requirement to allow 8.0 #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coord-e
force-pushed
the
activesupport-8.0
branch
from
1c61486 to
1b2b420
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 856 856
=========================================
Hits 856 856 ☔ View full report in Codecov by Sentry. |
|
@errm Could you check this, please? (no rush.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Active Support requirement of promenade to allow Rails 8.0. In my understanding, the main use of Active Support in promenade is the subscribers, and I don’t see anything interesting related to ActiveSupport::Subscriber and notifications in the 8.0 changelogs. https://github.com/rails/rails/blob/8-0-stable/activesupport/CHANGELOG.md
This PR also removes Ruby 3.1 (which is already EOL) from CI matrix.