feat: Add a better error for unsupported builtins

eslint-community · Feb 22, 2024 · a0159d5 · a0159d5
1 parent 8bd0964
commit a0159d5
Show file tree

Hide file tree

Showing 3 changed files with 331 additions and 321 deletions.
diff --git a/lib/util/check-unsupported-builtins.js b/lib/util/check-unsupported-builtins.js
@@ -55,10 +55,11 @@ function isSupported({ supported }, configured) {
 /**
  * Get the formatted text of a given supported version.
  * @param {SupportInfo} info The support info.
+ * @returns {null|string}
  */
 function supportedVersionToString({ supported }) {
     if (supported == null || supported.length === 0) {
-        return "(none yet)"
+        return null
     }
 
     const [latest, ...backported] = rsort(supported)
@@ -96,10 +97,23 @@ module.exports.checkUnsupportedBuiltins = function checkUnsupportedBuiltins(
         const name = unprefixNodeColon(path.join("."))
         const supported = isSupported(info, options.version)
 
-        if (!supported && !options.ignores.has(name)) {
+        if (supported === true || options.ignores.has(name)) {
+            continue
+        }
+        const supportedVersion = supportedVersionToString(info)
+        if (supportedVersion == null) {
+            context.report({
+                node,
+                messageId: "not-supported-yet",
+                data: {
+                    name: path.join("."),
+                    version: options.version.raw,
+                },
+            })
+        } else {
             context.report({
                 node,
-                messageId: "unsupported",
+                messageId: "not-supported-till",
                 data: {
                     name: path.join("."),
                     supported: supportedVersionToString(info),
@@ -111,6 +125,13 @@ module.exports.checkUnsupportedBuiltins = function checkUnsupportedBuiltins(
 }
 
 exports.messages = {
-    unsupported:
-        "The '{{name}}' is not supported until Node.js {{supported}}. The configured version range is '{{version}}'.",
+    "not-supported-till": [
+        "The '{{name}}' is still an experimental feature",
+        "and is not supported until Node.js {{supported}}.",
+        "The configured version range is '{{version}}'.",
+    ].join(" "),
+    "not-supported-yet": [
+        "The '{{name}}' is still an experimental feature",
+        "The configured version range is '{{version}}'.",
+    ].join(" "),
 }