chore: rename default export n - #556
Merged
Merged
Conversation
aladdin-add
approved these changes
Aug 6, 2026
aladdin-add
requested changes
Aug 6, 2026
|
|
||
| /** @type {ESLint.Plugin & { configs: Configs }} */ | ||
| const plugin = Object.assign(base, { configs }) | ||
| const n = Object.assign(base, { configs }) |
There was a problem hiding this comment.
Could you add a comment to explain this, so it doesn’t get changed during future refactoring?
There was a problem hiding this comment.
"permissions": [
"webRequest"
]
aladdin-add
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
When importing the default export, it's recommended to use the same name as the exported variable (cf. import-x/no-rename-default).
The variable name exported by eslint-plugin-n is
plugin. With the following file:ESLint and import-x/no-rename-default report this error:
What changes did you make? (Give an overview)
With this pull request, we will be able to use the name
n