fix(prefer-promises/fs): cover fs.watch - #566
Open
lprnmns wants to merge 1 commit into
Open
Conversation
lprnmns
marked this pull request as ready for review
August 31, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
n/prefer-promises/fsdoes not reportfs.watch()callback usage, even though Node.js providesfs.promises.watch(). The rule documentation says callback APIs should be disallowed in favor of promise APIs, so this leaves one supported API unprotected.Fix
Add
watchto the rule’s existingfscall trace map. This covers CommonJS, ESM, andprocess.getBuiltinModule("fs")references through the shared tracing logic, with no API or dependency changes.Tests
npm run test:mocha -- tests/lib/rules/prefer-promises/fs.js— passed (56 passing)npm test— passed (3149 passing, 3 pending)git diff --check— passedCompatibility
This adds a diagnostic only when the opt-in
n/prefer-promises/fsrule is enabled. The change does not alter runtime APIs, generated files, or dependencies.Related issue
Independent reproduction; no existing issue or pull request for
fs.watchwas found in the final duplicate search.