Skip to content

fix(prefer-readonly-type): mark rule as deprecated #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Jul 31, 2021

Fixes: #51
Fixes: #150
Fixes: #151
Fixes: #153

Deprecated in favor of prefer-readonly-type-alias and @typescript-eslint/prefer-readonly-parameter-types.

@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #246 (fd321ba) into next (2c29cf2) will decrease coverage by 3.48%.
The diff coverage is 73.14%.

❗ Current head fd321ba differs from pull request most recent head af16229. Consider uploading reports for the commit af16229 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             next     #246      +/-   ##
==========================================
- Coverage   95.41%   91.93%   -3.49%     
==========================================
  Files          35       36       +1     
  Lines         589      682      +93     
  Branches      143      179      +36     
==========================================
+ Hits          562      627      +65     
- Misses         13       32      +19     
- Partials       14       23       +9     
Impacted Files Coverage Δ
src/common/ignore-options.ts 100.00% <ø> (ø)
src/configs/functional-lite.ts 100.00% <ø> (ø)
src/configs/stylistic.ts 100.00% <ø> (ø)
src/rules/immutable-data.ts 100.00% <ø> (ø)
src/rules/no-return-void.ts 80.00% <63.63%> (-20.00%) ⬇️
src/rules/no-conditional-statement.ts 74.71% <66.15%> (-21.96%) ⬇️
src/util/conditional-imports/tsutils.ts 75.00% <75.00%> (ø)
src/util/typeguard.ts 88.69% <83.33%> (-0.63%) ⬇️
src/index.ts 100.00% <100.00%> (ø)
src/rules/prefer-readonly-type.ts 94.64% <100.00%> (+0.41%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd8a54...af16229. Read the comment docs.

@RebeccaStevens RebeccaStevens force-pushed the deprecate-prefer-readonly-type branch from f73edad to 93eaff0 Compare August 2, 2021 08:13
@RebeccaStevens RebeccaStevens added the Status: Blocked Progress on this issue is currently not possible. label Aug 7, 2021
@RebeccaStevens RebeccaStevens force-pushed the deprecate-prefer-readonly-type branch from 93eaff0 to fd321ba Compare August 7, 2021 08:30
@RebeccaStevens RebeccaStevens changed the base branch from master to next August 7, 2021 08:31
@RebeccaStevens RebeccaStevens force-pushed the deprecate-prefer-readonly-type branch from fd321ba to 1f098fb Compare August 7, 2021 08:31
@RebeccaStevens RebeccaStevens force-pushed the deprecate-prefer-readonly-type branch from 1f098fb to 959ba1a Compare August 12, 2021 14:02
@RebeccaStevens RebeccaStevens force-pushed the deprecate-prefer-readonly-type branch from 959ba1a to af16229 Compare August 12, 2021 14:10
@RebeccaStevens
Copy link
Collaborator Author

Closed in favor of #259

@RebeccaStevens RebeccaStevens deleted the deprecate-prefer-readonly-type branch August 28, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked Progress on this issue is currently not possible.
Projects
None yet
1 participant