Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadonlySet and ReadonlyMap #30

Merged
merged 7 commits into from
Jul 19, 2019
Merged

Conversation

RebeccaStevens
Copy link
Collaborator

Fixes #25

Based off #29

@RebeccaStevens RebeccaStevens added the Type: Enhancement Enhancement of the code, not introducing new features. label Jul 19, 2019
@RebeccaStevens RebeccaStevens force-pushed the readonlyset-readonlymap branch from 0150126 to 8ac0f25 Compare July 19, 2019 01:02
@codecov-io
Copy link

codecov-io commented Jul 19, 2019

Codecov Report

Merging #30 into master will decrease coverage by 0.49%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #30     +/-   ##
=========================================
- Coverage   91.29%   90.79%   -0.5%     
=========================================
  Files          29       28      -1     
  Lines         494      489      -5     
  Branches       95       97      +2     
=========================================
- Hits          451      444      -7     
- Misses         33       34      +1     
- Partials       10       11      +1
Impacted Files Coverage Δ
src/configs/immutable.ts 0% <ø> (ø) ⬆️
src/configs/all.ts 0% <ø> (ø) ⬆️
src/rules/index.ts 100% <ø> (ø) ⬆️
src/util/typeguard.ts 85.54% <100%> (+0.35%) ⬆️
src/rules/prefer-readonly-types.ts 93.75% <86.66%> (ø)
src/rules/immutable-data.ts 95.12% <0%> (ø) ⬆️
src/util/tree.ts 100% <0%> (ø) ⬆️
src/configs/external-recommended.ts 0% <0%> (ø) ⬆️
src/util/misc.ts 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02dd4b...45a1d69. Read the comment docs.

@RebeccaStevens RebeccaStevens merged commit b78d559 into master Jul 19, 2019
@RebeccaStevens RebeccaStevens deleted the readonlyset-readonlymap branch July 19, 2019 03:33
RebeccaStevens pushed a commit that referenced this pull request Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce ReadonlySet over Set, and ReadonlyMap over Map
2 participants