Added a rule for using lodash with destructuring assignments

README.md

@@ -45,6 +45,8 @@ Finally, enable all of the rules that you would like to use.
 # List of supported rules
 
 * [import](docs/rules/import.md): Prevent importing the entire lodash (or lodash-compat) library.
+* [import-destructed](docs/rules/import-destructed.md): Prevent importing the entire lodash library without using destructuring assignments.
+
 
 ## To Do
 

docs/rules/import-destructed.md

@@ -0,0 +1,21 @@
+# Enforce using destructuring when using lodash functions
+
+This rule enforces a cleaner codebase when using lodash's utility functions.
+
+## Rule Details
+
+The following patterns are considered warnings:
+
+```js
+import _ from 'lodash';
+```
+
+```js
+import 'lodash';
+```
+
+The following patterns are considered valid:
+
+```js
+import {find} from 'lodash';
+```

src/index.js

@@ -1,10 +1,13 @@
 import importRule from './rules/import';
+import importDestructedRule from './rules/import-destructed';
 
 export default {
   rules: {
-    'import': importRule
+    'import': importRule,
+    'import-destructed': importDestructedRule
   },
   rulesConfig: {
-    'import': 1
+    'import': 1,
+    'import-destructed': 1
   }
 };

src/rules/import-destructed.js

@@ -0,0 +1,28 @@
+/**
+ * @fileoverview Rule to enforce only allowing destructuring assignment when using lodash
+ * @author Richard van der Dys
+ * @copyright 2015 Matt Smith. All rights reserved.
+ */
+
+const message = 'Please use the destructuring assignment when using lodash functions';
+
+export default function(context) {
+  return {
+    ImportDeclaration(node) {
+      if (node.source.value === 'lodash') {
+        const vars = context.getDeclaredVariables(node);
+        if (vars.length === 0) {
+          context.report(node.source, message);
+        } else {
+          const names = vars[0].identifiers.map(id => id.name);
+          const usingEntireLibrary = names.some(name => {
+            return name === 'lodash' || name === '_';
+          });
+          if (usingEntireLibrary) {
+            context.report(node.source, message);
+          }
+        }
+      }
+    }
+  };
+}

test/rules/import-destructed.Spec.js

@@ -0,0 +1,47 @@
+import eslint from 'eslint';
+import 'babel-eslint';
+import rule from '../../src/rules/import-destructed';
+
+const ruleTester = new eslint.RuleTester();
+
+const message = 'Please use the destructuring assignment when using lodash functions';
+
+ruleTester.run('lodash/import-destructed', rule, {
+  valid: [
+    {
+      code: 'import {pluck, find} from "lodash"',
+      parser: 'babel-eslint'
+    },
+    {
+      code: 'import { pluck as plink } from "lodash"',
+      parser: 'babel-eslint'
+    },
+    {
+      code: 'import { pluck } from "lodash"',
+      parser: 'babel-eslint'
+    },
+  ],
+  invalid: [
+    {
+      code: 'import "lodash"',
+      parser: 'babel-eslint',
+      errors: [{
+        message
+      }]
+    },
+    {
+      code: 'import _ from "lodash"',
+      parser: 'babel-eslint',
+      errors: [{
+        message
+      }]
+    },
+    {
+      code: 'import lodash from "lodash"',
+      parser: 'babel-eslint',
+      errors: [{
+        message
+      }]
+    }
+  ]
+});