feat: config-helpers package #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Created a new
config-helperspackageWhat changes did you make? (Give an overview)
Added
packages/config-helpersdirectory..github/ISSUE_TEMPLATE/bug-report.ymland.github/ISSUE_TEMPLATE/change.yml: Added@eslint/config-helperslabel to the issue templates. [1] [2].github/workflows/release-please.yml: Added steps to publish the@eslint/config-helperspackage to npm and JSR, and to post release announcements..release-please-manifest.json: Added@eslint/config-helpersto the release manifest.README.md: Updated the list of packages to include@eslint/config-helpers.Related Issues
Refs eslint/eslint#19116
Is there anything you'd like reviewers to focus on?
UserConfig[index]and extended configs are nowExtendedConfig[index]. Using the bracket notation allows us to more clearly indicate the presence of a multidimensional array.extendsas an array of arrays at maximum instead of infinite nesting. I'd like to see how far we get with this.eslint/migrate-configpackage in this PR or a separate one. I opted for a separate one for now, but let me know if you think differently.