ISSUE-257: Humble (and experimental) attempt at dealing with stale/missing excerpts #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... on GET calls. This enables a new config option for our advanced highlighter and enables a very experimental lazy loading mechanism when needed, allowing still POST calls to get around the fact that they are "barely" cached... (except at the Views level, but we don't mess with that right? :( Also this whole day could have been a cache time set to 0 .... but i like people...
DiegoPino
added
enhancement
…nd most missing snippets Concerned about performance tbh
This also forces $hl->setRequireFieldMatch(TRUE); to avoid highlighting things that did not match all. This is fair. Most of this code depends on actual format_strawberry field views Filter (JOIN) one so needs to be tested together. There is more to do here but this looks clean. I could expose WAY more settings but for now we can roll with these defaults (e.g the snippets are going to be only of 128 max size Finally i made a "if this is autocomplete" bypass highlighting.That should be by default Drupal, like really!
DiegoPino
added a commit
to esmero/format_strawberryfield
that referenced
this pull request
Mar 29, 2023
…iews This is WIP but works. Why WIP? The settings are not all the ones i need And also i want to expose (checkboxes) if this is enabled or not Requires esmero/strawberryfield#258
|
This requires esmero/format_strawberryfield#287 to see it in action, but won't fail if not merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #257
... on GET calls.
This enables a new config option for our advanced highlighter and enables a very experimental lazy loading mechanism when needed, allowing still POST calls to get around the fact that they are "barely" cached... (except at the Views level, but we don't mess with that right? :( Also this whole day could have been a cache time set to 0 .... but i like people...
To be honest, I feel this is over engineered... I understand the use case and the need and I might develop this better/further soon. I don't know if even caching this beyond time to live 0 is more performant or not