Add serial ports config file #777
Open
+191
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurajSadel
reviewed
Feb 18, 2025
|
Not sure this is the path we want to take to be honest. Had some other ideas I've been meaning to explore, so let's sit on this for awhile please. |
SergioGasquez
force-pushed
the
feat/connections-file
branch
from
697ae3d to
a31daef
Compare
Co-authored-by: Juraj Sadel <[email protected]>
SergioGasquez
force-pushed
the
feat/connections-file
branch
from
a31daef to
6cc02c4
Compare
SergioGasquez
commented
May 21, 2025
| pid = "1001" | ||
| ``` | ||
| - Baudrate: | ||
| ## Configuration Files |
There was a problem hiding this comment.
Before merging, we would need to document this also in cargo-espflash
JurajSadel
reviewed
May 22, 2025
Co-authored-by: Juraj Sadel <[email protected]>
|
I wonder if we can test this somehow in HIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't really like the way I solved this as it's basically a bunch of duplicated code, but not sure if there's any better way.
Draft until I do some more testing and/or I find a better solution.
Example
espflash_ports.tomlfile: