Merge pull request #6360 from espoon-voltti/application-attachments-r…

…equired Lisätään mahdollisuus konfiguroida hakemuksen liitteet pakollisiksi
espoon-voltti · Feb 12, 2025 · 1945d15 · 1945d15
2 parents c68992b + e68f965
commit 1945d15
Show file tree

Hide file tree

Showing 5 changed files with 113 additions and 27 deletions.
diff --git a/frontend/src/citizen-frontend/applications/editor/service-need/PreferredStartSubSection.tsx b/frontend/src/citizen-frontend/applications/editor/service-need/PreferredStartSubSection.tsx
@@ -10,6 +10,7 @@ import LocalDate from 'lib-common/local-date'
 import { useIdRouteParam } from 'lib-common/useRouteParams'
 import { useUniqueId } from 'lib-common/utils/useUniqueId'
 import Checkbox from 'lib-components/atoms/form/Checkbox'
+import AdaptiveFlex from 'lib-components/layout/AdaptiveFlex'
 import ExpandingInfo from 'lib-components/molecules/ExpandingInfo'
 import FileUpload from 'lib-components/molecules/FileUpload'
 import { AlertBox } from 'lib-components/molecules/MessageBoxes'
@@ -127,12 +128,25 @@ export default React.memo(function PreferredStartSubSection({
               <>
                 <Gap size="s" />
 
-                <strong>
-                  {
-                    t.applications.editor.serviceNeed.urgent.attachmentsMessage
-                      .subtitle
-                  }
-                </strong>
+                <AdaptiveFlex>
+                  <strong>
+                    {
+                      t.applications.editor.serviceNeed.urgent
+                        .attachmentsMessage.subtitle
+                    }
+                  </strong>
+                  {verificationRequested &&
+                    errors.urgencyAttachments?.arrayErrors && (
+                      <AlertBox
+                        message={
+                          t.validationErrors[
+                            errors.urgencyAttachments.arrayErrors
+                          ]
+                        }
+                        thin
+                      />
+                    )}
+                </AdaptiveFlex>
 
                 <Gap size="s" />
 

diff --git a/...nd/src/citizen-frontend/applications/editor/service-need/ServiceTimeSubSectionDaycare.tsx b/...nd/src/citizen-frontend/applications/editor/service-need/ServiceTimeSubSectionDaycare.tsx
@@ -12,6 +12,7 @@ import { useIdRouteParam } from 'lib-common/useRouteParams'
 import Checkbox from 'lib-components/atoms/form/Checkbox'
 import Radio from 'lib-components/atoms/form/Radio'
 import TimeInput from 'lib-components/atoms/form/TimeInput'
+import AdaptiveFlex from 'lib-components/layout/AdaptiveFlex'
 import {
   FixedSpaceColumn,
   FixedSpaceRow
@@ -296,9 +297,20 @@ export default React.memo(function ServiceTimeSubSectionDaycare({
 
           <Gap size="s" />
 
-          <strong>
-            {t.applications.editor.serviceNeed.shiftCare.attachmentsSubtitle}
-          </strong>
+          <AdaptiveFlex>
+            <strong>
+              {t.applications.editor.serviceNeed.shiftCare.attachmentsSubtitle}
+            </strong>
+            {verificationRequested &&
+              errors.shiftCareAttachments?.arrayErrors && (
+                <AlertBox
+                  message={
+                    t.validationErrors[errors.shiftCareAttachments.arrayErrors]
+                  }
+                  thin
+                />
+              )}
+          </AdaptiveFlex>
 
           <Gap size="s" />
 

diff --git a/frontend/src/citizen-frontend/applications/editor/validations.ts b/frontend/src/citizen-frontend/applications/editor/validations.ts
@@ -18,7 +18,10 @@ import {
   TIME_REGEXP,
   validate
 } from 'lib-common/form-validation'
-import { ApplicationDetails as ApplicationDetailsGen } from 'lib-common/generated/api-types/application'
+import {
+  ApplicationAttachment,
+  ApplicationDetails as ApplicationDetailsGen
+} from 'lib-common/generated/api-types/application'
 import LocalDate from 'lib-common/local-date'
 import { featureFlags } from 'lib-customizations/citizen'
 
@@ -67,6 +70,26 @@ const preferredStartDateValidator =
       ? undefined
       : err
 
+export const getUrgencyAttachmentValidStatus = (
+  urgent: boolean,
+  urgencyAttachments: ApplicationAttachment[]
+) =>
+  urgent && urgencyAttachments.length === 0 && featureFlags.urgencyAttachments
+    ? featureFlags.requireAttachments
+      ? 'require'
+      : 'notify'
+    : undefined
+
+export const getShiftCareAttachmentsValidStatus = (
+  shiftCare: boolean,
+  shiftCareAttachments: ApplicationAttachment[]
+) =>
+  shiftCare && shiftCareAttachments.length === 0
+    ? featureFlags.requireAttachments
+      ? 'require'
+      : 'notify'
+    : undefined
+
 export const validateApplication = (
   apiData: ApplicationDetailsGen,
   form: ApplicationFormData,
@@ -125,7 +148,36 @@ export const validateApplication = (
           : undefined,
       assistanceDescription: form.serviceNeed.assistanceNeeded
         ? required(form.serviceNeed.assistanceDescription)
-        : undefined
+        : undefined,
+      urgencyAttachments:
+        getUrgencyAttachmentValidStatus(
+          form.serviceNeed.urgent,
+          form.serviceNeed.urgencyAttachments
+        ) === 'require'
+          ? {
+              arrayErrors: 'required',
+              itemErrors: form.serviceNeed.urgencyAttachments.map(() => ({
+                id: undefined,
+                name: undefined
+              }))
+            }
+          : undefined,
+      shiftCareAttachments:
+        getShiftCareAttachmentsValidStatus(
+          form.serviceNeed.shiftCare,
+          form.serviceNeed.shiftCareAttachments
+        ) === 'require'
+          ? {
+              arrayErrors:
+                form.serviceNeed.shiftCareAttachments.length === 0
+                  ? 'required'
+                  : undefined,
+              itemErrors: form.serviceNeed.shiftCareAttachments.map(() => ({
+                id: undefined,
+                name: undefined
+              }))
+            }
+          : undefined
     },
     unitPreference: {
       siblingName:

diff --git a/...end/src/citizen-frontend/applications/editor/verification/ApplicationVerificationView.tsx b/...end/src/citizen-frontend/applications/editor/verification/ApplicationVerificationView.tsx
@@ -15,13 +15,16 @@ import RoundIcon from 'lib-components/atoms/RoundIcon'
 import Container, { ContentArea } from 'lib-components/layout/Container'
 import { H1, P } from 'lib-components/typography'
 import { defaultMargins, Gap } from 'lib-components/white-space'
-import { featureFlags } from 'lib-customizations/citizen'
 import colors from 'lib-customizations/common'
 import { faInfo } from 'lib-icons'
 
 import BasicsSection from '../../../applications/editor/verification/BasicsSection'
 import UnitPreferenceSection from '../../../applications/editor/verification/UnitPreferenceSection'
 import { useTranslation } from '../../../localization'
+import {
+  getShiftCareAttachmentsValidStatus,
+  getUrgencyAttachmentValidStatus
+} from '../validations'
 
 import AdditionalDetailsSection from './AdditionalDetailsSection'
 import ContactInfoSection from './ContactInfoSection'
@@ -52,14 +55,18 @@ export default React.memo(function ApplicationVerificationViewDaycare({
 }: DaycareApplicationVerificationViewProps) {
   const t = useTranslation()
   const missingUrgencyAttachments =
-    formData.serviceNeed.urgent &&
-    formData.serviceNeed.urgencyAttachments.length === 0 &&
-    featureFlags.urgencyAttachments
+    getUrgencyAttachmentValidStatus(
+      formData.serviceNeed.urgent,
+      formData.serviceNeed.urgencyAttachments
+    ) === 'notify'
+  const missingShiftCareAttachments =
+    getShiftCareAttachmentsValidStatus(
+      formData.serviceNeed.shiftCare,
+      formData.serviceNeed.shiftCareAttachments
+    ) === 'notify'
 
   const missingAttachments =
-    missingUrgencyAttachments ||
-    (formData.serviceNeed.shiftCare &&
-      formData.serviceNeed.shiftCareAttachments.length === 0)
+    missingUrgencyAttachments || missingShiftCareAttachments
   return (
     <Container>
       <ContentArea opaque>
@@ -83,15 +90,11 @@ export default React.memo(function ApplicationVerificationViewDaycare({
                     {t.applications.editor.verification.attachmentBox.urgency}
                   </li>
                 )}
-                {formData.serviceNeed.shiftCare &&
-                  formData.serviceNeed.shiftCareAttachments.length === 0 && (
-                    <li>
-                      {
-                        t.applications.editor.verification.attachmentBox
-                          .shiftCare
-                      }
-                    </li>
-                  )}
+                {missingShiftCareAttachments && (
+                  <li>
+                    {t.applications.editor.verification.attachmentBox.shiftCare}
+                  </li>
+                )}
               </ul>
               <P>
                 <a href="#" onClick={closeVerification} role="button">

diff --git a/frontend/src/lib-customizations/types.d.ts b/frontend/src/lib-customizations/types.d.ts
@@ -280,6 +280,11 @@ interface BaseFeatureFlags {
    */
   multiSelectDeparture?: boolean
 
+  /**
+   * Missing attachments as an error
+   */
+  requireAttachments?: boolean
+
   /**
    * Enable support for citizen weak login
    */