bootloader: fix build with CONFIG_CONSOLE_UART_NONE (GIT8266O-824)#1247
Open
f00b4r0 wants to merge 1 commit intoespressif:masterfrom
Open
bootloader: fix build with CONFIG_CONSOLE_UART_NONE (GIT8266O-824)#1247f00b4r0 wants to merge 1 commit intoespressif:masterfrom
f00b4r0 wants to merge 1 commit intoespressif:masterfrom
Conversation
Setting CONFIG_CONSOLE_UART_NONE would trigger the following error:
ESP8266_RTOS_SDK/components/bootloader_support/src/bootloader_init.c: In function 'uart_console_configure':
ESP8266_RTOS_SDK/components/bootloader_support/src/bootloader_init.c:628:80:
error: 'CONFIG_ESP_CONSOLE_UART_BAUDRATE' undeclared (first use in this function); did you mean 'CONFIG_ESP_CONSOLE_UART_NUM'?
uart_div_modify(CONFIG_ESP_CONSOLE_UART_NUM, BOOTLOADER_CONSOLE_CLK_FREQ / CONFIG_ESP_CONSOLE_UART_BAUDRATE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CONFIG_ESP_CONSOLE_UART_NUM
This is because ESP8266_MODIFY_UART_BAUDRATE is unconditionally defined,
even when CONFIG_CONSOLE_UART_NONE is set. This commit fixes this.
Author
|
FWIW even with And that, even though GDB stub is not enabled: It seems completely disabling serial output isn't supported and would need more work; not sure if there's interest for this? |
Could be output from wifi code using early boot-time console. I had to "plug" it with #1253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting CONFIG_CONSOLE_UART_NONE would trigger the following error:
This is because
ESP8266_MODIFY_UART_BAUDRATEis unconditionally defined, even whenCONFIG_CONSOLE_UART_NONEis set.This commit fixes this.