-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(board): Add Alfredo NoU3 #10134
Conversation
Add board support for Alfredo Systems NoU3. https://www.alfredosys.com/products/alfredo-nou3/
👋 Hello BotSpace, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @botspace, PTAL on my comment.
The boards.txt
addition looks fine, but the pins_arduino.h
file is missing a lot of pins declarations.
I appreciate the swift explanation, I promise I did a lot of research and testing before putting in this PR, but I am in a little over my head here still. If I'm being honest I would prefer not to define pins this way. to me it seems unnecessary, because the esp32s3 has an internal pin mux, any pin can be any function (except for touch and ADC). If users want to use touch and ADC, they are going to need to look up what those pins are anyway, so A1 or T1 definitions do not help them much. For RX and TX definitions, I don't understand what those definitions are being used for. My board is intended to be used with JTAG upload mode and Hardware CDC serial debugging on GPIO 19 and 20. I'm afraid if I define RX and TX to those pins, they might get set as UART pins instead of JTAG or OTG pins. There are no other pins intended for serial on the NoU3. I'm happy to use the SCL and SDA definitions as my board is qwiic compatible on GPIO 34 and 35. But like serial, there are no pins intended for SPI on my board, I would rather leave that up to the user. I included a random SS pin in my latest commit because that is defiantly needed in CIBoardsTest.ino If the test fails again I suppose I will just have to add some random serial pins and the rest of the SPI pins. Any insight on what is strictly necessary would be appreciated! |
@botspace the SPI and I2C pins are needed because of how the core is written. But if you don't want to specify them, you can use -1 instead. By that the default pins will be used. For TX and RX I think it's ok to not declare them. Let's see if CI is would be happy not having the TX and RX. But I agree, as your board is not intended to be used with UART, it should be fine to not define those pins. I also agree that touch and ADC pins are not necessary to be there, but maybe you can define some pins specifically for your board. As I see you have some DC motor ports, sensors etc. That would be very useful for users to have those pins defined. |
@botspace Will you do any action regarding the pins for DS motors, sensors etc? Also please update your branch with master and resolve conflicts. Thanks |
Thanks again for the help. I'm not planning on adding more defs for motors/sensors, I think it makes more sense to have that handled by my library for the board. I merged my branch with upstream master, hopefully everything is in order now. |
Add board support for Alfredo Systems NoU3.
https://www.alfredosys.com/products/alfredo-nou3/