Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3rd party board): Add Fri3d Badge 2024 (ESP32-S3-WROOM-1) #10143

Merged

Conversation

francisduvivier
Copy link
Contributor

Description of Change

Add Fri3d Badge 2024 (ESP32-S3-WROOM-1) as a new 3rd party board

Tests scenarios

I have tested my PR on the Fri3d Badge 2024 (ESP32-S3-WROOM-1)

Related links

Board Image: https://github.com/Fri3dCamp/badge_2024/blob/main/docs/badge2024.jpg
More info on https://github.com/Fri3dCamp/badge_2024

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Aug 11, 2024

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello francisduvivier, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2a081ee

@francisduvivier
Copy link
Contributor Author

If I want to get this board in the v2.0.x release, should I then also make a PR towards the release/v2.0.x branch?

@francisduvivier francisduvivier force-pushed the feature/fri3d_badge_2024_esp32-s3 branch 3 times, most recently from 274a397 to 52ad3b4 Compare August 11, 2024 20:46
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francisduvivier PTAL on my comments.

@P-R-O-C-H-Y
Copy link
Member

If I want to get this board in the v2.0.x release, should I then also make a PR towards the release/v2.0.x branch?

If you want to get the board to the 2.x branch, you can open the PR targeting that branch. But it's not recommended anymore as IDF 4.4 is EOL and we don't have any plans to release a new 2.X version.

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change needed :)

@francisduvivier francisduvivier force-pushed the feature/fri3d_badge_2024_esp32-s3 branch from c31fc21 to 7720649 Compare August 13, 2024 17:48
@francisduvivier
Copy link
Contributor Author

If I want to get this board in the v2.0.x release, should I then also make a PR towards the release/v2.0.x branch?

If you want to get the board to the 2.x branch, you can open the PR targeting that branch. But it's not recommended anymore as IDF 4.4 is EOL and we don't have any plans to release a new 2.X version.

Ah very good to know, thanks for the info!

@francisduvivier francisduvivier force-pushed the feature/fri3d_badge_2024_esp32-s3 branch from b086da1 to 64d834d Compare August 14, 2024 06:36
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francisduvivier Last few requests and suggestions, mostly related to the module you use on your board, which is ESP32-S3-WROOM-1-N16R8 with 16MB flash and 8MB OPI PSRAM. It's good to remove the options which are not possible to avoid crashing due to wrong selection. PTAL :)

@francisduvivier
Copy link
Contributor Author

@francisduvivier Last few requests and suggestions, mostly related to the module you use on your board, which is ESP32-S3-WROOM-1-N16R8 with 16MB flash and 8MB OPI PSRAM. It's good to remove the options which are not possible to avoid crashing due to wrong selection. PTAL :)

Thanks again for the help! I applied all suggestions in a new commit.

@francisduvivier francisduvivier force-pushed the feature/fri3d_badge_2024_esp32-s3 branch from c883cc3 to ef1e578 Compare August 14, 2024 19:16
@francisduvivier francisduvivier force-pushed the feature/fri3d_badge_2024_esp32-s3 branch from ed682bb to 66c1370 Compare August 15, 2024 14:38
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Resolution: Awaiting response Waiting for response of author labels Aug 15, 2024
@me-no-dev me-no-dev merged commit f53f2dc into espressif:master Aug 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants