-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(3rd party board): Add Fri3d Badge 2024 (ESP32-S3-WROOM-1) #10143
feat(3rd party board): Add Fri3d Badge 2024 (ESP32-S3-WROOM-1) #10143
Conversation
👋 Hello francisduvivier, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
If I want to get this board in the v2.0.x release, should I then also make a PR towards the |
274a397
to
52ad3b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francisduvivier PTAL on my comments.
If you want to get the board to the 2.x branch, you can open the PR targeting that branch. But it's not recommended anymore as IDF 4.4 is EOL and we don't have any plans to release a new 2.X version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change needed :)
c31fc21
to
7720649
Compare
Ah very good to know, thanks for the info! |
b086da1
to
64d834d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francisduvivier Last few requests and suggestions, mostly related to the module you use on your board, which is ESP32-S3-WROOM-1-N16R8
with 16MB flash and 8MB OPI PSRAM. It's good to remove the options which are not possible to avoid crashing due to wrong selection. PTAL :)
Thanks again for the help! I applied all suggestions in a new commit. |
c883cc3
to
ef1e578
Compare
ed682bb
to
66c1370
Compare
Description of Change
Add Fri3d Badge 2024 (ESP32-S3-WROOM-1) as a new 3rd party board
Tests scenarios
I have tested my PR on the Fri3d Badge 2024 (ESP32-S3-WROOM-1)
Related links
Board Image: https://github.com/Fri3dCamp/badge_2024/blob/main/docs/badge2024.jpg
More info on https://github.com/Fri3dCamp/badge_2024