Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zigbee): Fix rejoin issue for battery powered devices #10704

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

TBD

Tests scenarios

TBD

Related links

Closes #10612

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Dec 10, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: In Progress Issue is in progress label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Warnings
⚠️ Please consider squashing your 7 commits (simplifying branch history).
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3a8d4c5

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3a8d4c5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C60‼️ +18K0.00‼️ +3.460⚠️ +16960.00‼️ +5.71
ESP32H20‼️ +15K0.00‼️ +2.710⚠️ +16040.00‼️ +5.53
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light‼️ +18K⚠️ +1680‼️ +15K⚠️ +1580
Zigbee/examples/Zigbee_Color_Dimmer_Switch‼️ +10K⚠️ +944‼️ +7K⚠️ +860
Zigbee/examples/Zigbee_On_Off_Light‼️ +18K⚠️ +1696‼️ +14K⚠️ +1604
Zigbee/examples/Zigbee_On_Off_Switch‼️ +11K⚠️ +920‼️ +7K⚠️ +860
Zigbee/examples/Zigbee_Scan_Networks‼️ +14K⚠️ +1260‼️ +10K⚠️ +1128
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy‼️ +16K⚠️ +980‼️ +12K⚠️ +832
Zigbee/examples/Zigbee_Temperature_Sensor‼️ +13K⚠️ +952‼️ +9K⚠️ +836
Zigbee/examples/Zigbee_Thermostat‼️ +12K⚠️ +616‼️ +9K⚠️ +540

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review and removed Status: In Progress Issue is in progress labels Dec 11, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.1.0 milestone Dec 11, 2024
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 11, 2024
@me-no-dev me-no-dev merged commit 83165f3 into espressif:release/v3.1.x Dec 11, 2024
48 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

4 participants