-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zigbee): Add Analog endpoint device (input, output, value clusters) #10950
Conversation
👋 Hello pwclay, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 80 files 80 suites 12m 53s ⏱️ For more details on these failures, see this check. Results for commit 21a840f. ♻️ This comment has been updated with latest results. |
Hi @pwclay, I can help with this PR. Can I take over to finish it and also to fix the CI error? |
Hi @P-R-O-C-H-Y thanks for your help in getting to this point. If you would take over it would be appreciated, I am not sure of what is needed to proceed. Cheers |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
@pwclay Hi, can you take a look? I have added also an Input/Output clusters and fixed some stuff, as reporting analog value attribute is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
Adds analog sensor type to the zigbee library
Tests scenarios
Tested on ESP32-C6 & H2 using Arduino 2.3.4 & espressif 3.1.1. Device is visible to Home Assistant using ZHA
The code does not allow the description or units of the sensor to be set. From my limited understanding, it seems this would require a change in esp_zigbee_type.h buried deep in the board specific directories. Assistance improving this would be appreciated.
Related links
N/A