Skip to content

ci(idf): Use included IDF examples in CI #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci(idf): Use included IDF examples in CI #11240

wants to merge 1 commit into from

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Apr 11, 2025 •
edited
Loading

Description of Change

Add compilation test of our existing ESP-IDF examples to CI

Tests scenarios

CI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d9a0e9c

@lucasssvaz lucasssvaz force-pushed the ci/idf_examples branch 2 times, most recently from e111001 to 53d8c55 Compare April 14, 2025 12:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

Test Results

 76 files   76 suites   13m 2s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit d9a0e9c.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz force-pushed the ci/idf_examples branch 3 times, most recently from c994244 to d67a19b Compare April 14, 2025 15:48
@lucasssvaz lucasssvaz force-pushed the ci/idf_examples branch 2 times, most recently from 3e4f23e to d9a0e9c Compare April 15, 2025 12:37
@lucasssvaz lucasssvaz marked this pull request as ready for review April 15, 2025 12:59
@lucasssvaz lucasssvaz self-assigned this Apr 15, 2025
@lucasssvaz lucasssvaz added Type: CI & Testing Area: Arduino as ESP-IDF component Issues about Arduino used as component in ESP-IDF labels Apr 15, 2025
@SuGlider
Copy link
Collaborator

@lucasssvaz - what is the reason for removing matter_light specific target default sdkconfig? Those are examples.

@SuGlider
Copy link
Collaborator

@lucasssvaz - what is the reason for removing matter_light specific target default sdkconfig? Those are examples.

We already talked about it - question answered.

SuGlider
SuGlider approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason2866
Copy link
Collaborator

@SuGlider Is it planned to adopt the example to work with actual Arduino Core 3.2.0?
Currently it is only for Arduino Core ~3.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@lucasssvaz lucasssvaz

Labels
Area: Arduino as ESP-IDF component Issues about Arduino used as component in ESP-IDF Type: CI & Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasssvaz @SuGlider @Jason2866 @P-R-O-C-H-Y