-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix(ESP_SR): crash on watchdog timeout in iddle task #11376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello vlastahajek, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 45s ⏱️ Results for commit c6a81c2. ♻️ This comment has been updated with latest results. |
libraries/ESP_SR/src/esp32-hal-sr.c
Outdated
@@ -192,6 +192,7 @@ static void audio_feed_task(void *arg) { | |||
|
|||
/* Feed samples of an audio stream to the AFE_SR */ | |||
g_sr_data->afe_handle->feed(g_sr_data->afe_data, audio_buffer); | |||
vTaskDelay(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will suggest to delay 2 ticks instead. That will ensure that there will be enough time for the schedules to switch the tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
d6df469
to
c6a81c2
Compare
Btw, @me-no-dev , would it be helpful if I created a PR with a partition table (and build hacks) for 8MB flash devices for SR example? |
Definitely! Please go ahead |
Description of Change
Fixing the crash that occurs after the wake-up word is recognized:
Tests scenarios
Arduino Core ESP32 3.20
ESP32-S3 (ESP-S3-12k) N8R8 - ESP32S3Dev board used.
Custom partition table.