Skip to content

Conversation

@JakubAndrysek
Copy link
Collaborator

Description of Change

This pull request significantly expands and refactors the GPIO validation test suite. The main improvements include adding LED testing to the hardware diagrams, replacing the previous scenario-based button test with a comprehensive set of GPIO and interrupt validation tests, and updating the Python test script to coordinate detailed hardware interactions and assertions. These changes enhance the coverage and reliability of GPIO feature validation across multiple ESP32 variants.

Test coverage and scenario refactor:

  • The old scenario-based button counter test (scenario.yaml) is removed and replaced with a new, more granular test structure that validates both reading and writing GPIO states, as well as various interrupt behaviours.

Test Scenarios

I have tested my Pull Request on Arduino-esp32 core v3.3.3 with Wokwi on all available ESP32s mentioned in the test cases.

==================================================
SUMMARY
==================================================
esp32: SUCCESS
esp32c3: SUCCESS
esp32c6: SUCCESS
esp32h2: SUCCESS
esp32p4: SUCCESS
esp32s2: SUCCESS
esp32s3: SUCCESS
All operations completed successfully

@github-actions
Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(gpio): Enhance GPIO validation tests with interrupt handling and button functionality":
    • summary appears to be too long

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello JakubAndrysek, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b6e6bcb

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Test Results

 76 files   76 suites   19m 53s ⏱️
 38 tests  37 ✅ 0 💤 1 ❌
241 runs  234 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit b6e6bcb.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. CI Failure Expected For PRs where CI failure is expected labels Nov 12, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Nov 12, 2025
@me-no-dev me-no-dev self-requested a review November 12, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Failure Expected For PRs where CI failure is expected Status: Review needed Issue or PR is awaiting review Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants