Fix BLEClient handling of app registration results #4055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On closer consideration, this may not be the root problem, I think the issue is that the gattc_if is not being set properly at initial client registration. I'll update this PR after verifying. |
buxtronix
changed the title
|
Hm no, it seems the first commit works, not the second, but still doesnt seem to be the root cause. I'll close this and dig a bit more. |
|
IIRC esp_ble_server is using gatt_if to distinguish connected peers, but esp_ble_client is using conn_id. |
kind3r
added a commit
to kind3r/arduino-esp32
that referenced
this pull request
Jan 24, 2021
Cleanup before calling disconnect callback for safe delete. Reject other events during registration. Adresses espressif#4047, espressif#4055
me-no-dev
pushed a commit
that referenced
this pull request
Feb 16, 2021
- Remove client from the list of devices in case registration fails - Filter other events not related to registration during registration phase - Cleanup if connect fails - Reset if after disconnect - Disconnect callback *after* cleanup is done so object can be deleted This fixes some of the issues I had like: - `BLEClient::connect` hangs up and never recovered because registration failed - `BLEClient` could not be deleted after disconnect or deletion creating ghost events #4047 - `BLEClient` could not be properly reused after a connection was attempted (successful or not) * Cleanup in case of registration and connect failure. Cleanup before calling disconnect callback for safe delete. Reject other events during registration. Adresses #4047, #4055 * Clear if after unregister #4047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GATTC events are propagated to all clients, however clients should only act on events directed at their connection (conn_id). This fixes this so that clients ignore events not for them.