uartEnd: Unlock mutex before detaching rx and tx #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should solve the device freezing issue when Serial.end() is called
|
Verified with the following code: Serial Output |
|
Ahh seems to be the issue with #513 as well... |
|
This indeed fixes my problem with Serial.end(), so im closing #513 ... |
me-no-dev
reviewed
Aug 3, 2017
cores/esp32/esp32-hal-uart.c
Outdated
| @@ -227,12 +227,12 @@ void uartEnd(uart_t* uart) | |||
| while(xQueueReceive(uart->queue, &c, 0)); | |||
| vQueueDelete(uart->queue); | |||
| } | |||
| UART_MUTEX_UNLOCK(); | |||
|
|
|||
| uartDetachRx(uart); | |||
| uartDetachTx(uart); | |||
|
|
|||
| uart->dev->conf0.val = 0; | |||
There was a problem hiding this comment.
leave this line inside the lock ;)
* Thanks to @me-no-dev for pointing it out that uart->dev->conf0.val can be inside mutex lock
|
Done @me-no-dev :) |
Raienryu97
added a commit
to Raienryu97/arduino-esp32
that referenced
this pull request
Aug 4, 2017
* uartEnd: Unlock mutex before detaching rx and tx This should solve the device freezing issue when Serial.end() is called * Unlock UART MUTEX only for detaching Rx and Tx * Thanks to @me-no-dev for pointing it out that uart->dev->conf0.val can be inside mutex lock
Raienryu97
added a commit
to Raienryu97/arduino-esp32
that referenced
this pull request
Aug 6, 2017
* uartEnd: Unlock mutex before detaching rx and tx This should solve the device freezing issue when Serial.end() is called * Unlock UART MUTEX only for detaching Rx and Tx * Thanks to @me-no-dev for pointing it out that uart->dev->conf0.val can be inside mutex lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the device freezing issue when Serial.end() is called