-
Notifications
You must be signed in to change notification settings - Fork 7.6k
BLE upgrades #7867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE upgrades #7867
Conversation
@PilnyTomas - There are commits from 2022 in this PR. Is it right? |
To be honest, I don't know how they got there, but considering that they are mostly just merges of master it shouldn't be a problem. The only change was adding the vector #include, but as is not needed I have removed it in one of the following commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all examples. Everything works as expected. Just some indentation problems, mainly where std::string
s were replaced by String
s
Co-authored-by: Lucas Saavedra Vaz <[email protected]>
Related to the BLE refactoring: #7702 |
Closed in favor of #8724 |
General:
BREAKING CHANGE! Changed API return and parameter type from
std::tring
to Arduino styleString
.Renamed library name from
ESP32 BLE Arduino
to simpleBLE
.Created a new function
getFrame
which returns complete data forBLEAdvertisementData::addData()
.Renamed example files - removed prefix
BLE_
-BLE5_
is left unchanged.Beacon_Scanner
example updated to reflect changes in API - shortened by 28 lines on TLM and URL part.Changed UUID data type from
uint16_t
toBLEUUID
classEddysstone URL:
Created a new constructor which takes as an argument a
BLEAdvertisedDevice
object and initializes URL data from the payload.Created a new function
BLEEddystoneURL::setSmartURL
which encodes the full URL structure.Static frame data no longer needs to be written by the user - they are initialized by the constructor.
Function
BLEEddystoneURL::setPower
now acceptsesp_power_level_t
.Updated
EddystoneURL_Beacon
example to reflect changes in API - shortened by 83 lines.Added comments with explanations to functions
setData
andsetURL
.Tests:
EddystoneURL_Beacon
with the following URLs and read them inBeacon_Scanner
example and using an Android app nRF Connect for Mobile.Eddystone TLM:
Created a new constructor which takes as an argument a
BLEAdvertisedDevice
object and initializes TLM data from the payload.Added comments with explanations to functions
setData
andsetVolt
TODO: test all examples if they are properly working - changes related to the String might have broken something!
Related task: #7841