-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lechee check on PR is checking whole portal, instead of just modified content #101
Comments
#107 limits link checking by pr-check-links to the PR diffs only. |
There were numerous false positives in recent PRs. Analyzing false positives yielded the following results:
Actions required:
|
Summary of work doneThis PR implements link checking in diffs. To be more precise, the links that exist in main's latest commit are added to On a number of occasions, broken links from the main branch were reported. It was decided to dump links from main only until the commit at which a feature branch was forked (base commit). That would provide more predictable results. It appeared that main branches in forks were sometimes not rebased for a while, and the feature branches was rebased on This PR changes the branch against which the base commit is determined from hard-coded Follow-up actionsThe same links from old commits still occasionally pop up in different PRs. During work on #379, it became clear that even though files containing false positives are not changed in PRs directly, Hugo still updates them. More information can be found in #379 and further investigation is needed. |
The check should be localized only to added content, because otherwise the merge might fail in case of malfunction of url in unrelated content.
The text was updated successfully, but these errors were encountered: