Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix invalid dfrobot link #379

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

f-hollow
Copy link
Collaborator

@f-hollow f-hollow commented Jan 6, 2025

Description

This PR fixes a link that the workflow Check links in diffs identifies as a false positive:

https://www.dfrobot.com/index.php?route=information%2Finformation&information_id=4

Even though it is, the diffs don't include this change, so this workflow should not report it.

There are two issues that I noticed with regard to this link:

  • If ? is escaped (\?), it resolves the issue, but there are many other links with question marks that are not reported... Not sure why it happens yet.
  • If I compare checksums (see ci: optimize file syncing with s3 #381) of all files in public/, the file containing this link was reported as updated, however there were no changes in commits. There might be issues where Hugo updates this file for some reason.

This is not the only case where such things happened:

  • Workflow: https://github.com/espressif/developer-portal/actions/runs/12581829981/job/35066328929
    • File: ./content/blog/july-2019/index.md
    • Link: https://www.dfrobot.com/index.php?route=information%2Finformation&information_id=4
  • Workflow: https://github.com/espressif/developer-portal/actions/runs/12299931534/job/34326856344
  • Workflow: https://github.com/espressif/developer-portal/actions/runs/12199519835/job/34035160980

We need to find a solution to avoid bothering our contributors with such false positives.

Related

Testing

To be done later


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@f-hollow f-hollow requested a review from pedrominatel January 6, 2025 10:54
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@f-hollow f-hollow merged commit 873b733 into espressif:main Jan 6, 2025
4 checks passed
@f-hollow f-hollow deleted the feat/fix_invalid_links branch January 6, 2025 11:04
@f-hollow f-hollow mentioned this pull request Jan 9, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants