Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a link that the workflow
Check links in diffs
identifies as a false positive:https://www.dfrobot.com/index.php?route=information%2Finformation&information_id=4
Even though it is, the diffs don't include this change, so this workflow should not report it.
There are two issues that I noticed with regard to this link:
?
is escaped (\?
), it resolves the issue, but there are many other links with question marks that are not reported... Not sure why it happens yet.public/
, the file containing this link was reported as updated, however there were no changes in commits. There might be issues where Hugo updates this file for some reason.This is not the only case where such things happened:
https://github.com/espressif/developer-portal/actions/runs/12581829981/job/35066328929
./content/blog/july-2019/index.md
https://www.dfrobot.com/index.php?route=information%2Finformation&information_id=4
https://github.com/espressif/developer-portal/actions/runs/12299931534/job/34326856344
https://github.com/espressif/developer-portal/actions/runs/12199519835/job/34035160980
We need to find a solution to avoid bothering our contributors with such false positives.
Related
Testing
To be done later
Checklist
Before submitting a Pull Request, please ensure the following: