Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing brace in Gatt_Server_Example_Walkthrough.md (IDFGH-11590) #12709

Closed
wants to merge 1 commit into from

Conversation

Harrisonust
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Dec 2, 2023

Warnings
⚠️ The PR description looks very brief, please check if more details can be added.

👋 Welcome Harrisonust, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against 303a053

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 2, 2023
@github-actions github-actions bot changed the title Add missing brace in Gatt_Server_Example_Walkthrough.md Add missing brace in Gatt_Server_Example_Walkthrough.md (IDFGH-11590) Dec 2, 2023
@esp-zhp
Copy link
Collaborator

esp-zhp commented Dec 4, 2023

Thank you for your report. In the future, we will optimize the documents.

@esp-zhp
Copy link
Collaborator

esp-zhp commented Dec 16, 2024

fixed f812863

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels Dec 16, 2024
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants