-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esp-tls): Remove useless const from size paramter (IDFGH-14099) #14909
base: master
Are you sure you want to change the base?
fix(esp-tls): Remove useless const from size paramter (IDFGH-14099) #14909
Conversation
👋 Hello 0xFEEDC0DE64, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
f3afd06
to
4bbff34
Compare
Hi @0xFEEDC0DE64, The parameter has been marked as |
I just need to be able to build that struct from c++ code without having all the data already available on construction. Please never make any class members const as this breaks anything like copy constructors and so on |
I see, I think this should be okay. Since we specifically use a Can you please update the commit message to something like |
Get rid of useless const from size parameter as it does not allow for easy setup of the struct