fix(websocket): free cfg->host before reassignment to prevent memory leak - #1124
Open
gabsuren wants to merge 1 commit into
Open
fix(websocket): free cfg->host before reassignment to prevent memory leak#1124gabsuren wants to merge 1 commit into
gabsuren wants to merge 1 commit into
Conversation
| } | ||
|
|
||
| if (config->host) { | ||
| free(cfg->host); |
Collaborator
There was a problem hiding this comment.
Should we free it before assignment? Have you considered the paths that call this function? Perhaps we should be able to restore the old config in case of failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Single-line memory-management fix in config setup; behavior is unchanged except preventing leaks on repeated host updates.
Overview
Fixes a memory leak when the WebSocket client config’s host string is updated in
esp_websocket_client_set_config.The change adds
free(cfg->host)before assigning a newstrdup(config->host), aligning host handling with other string fields in the same function (username, password, uri, path, etc.). Without it, any priorcfg->hostallocation is orphaned whenconfig->hostis applied again.Reviewed by Cursor Bugbot for commit 18a9758. Bugbot is set up for automated code reviews on this repo. Configure here.