-
Notifications
You must be signed in to change notification settings - Fork 155
feat(common): Add ESP DNS module with support for UDP, DoT, and DoH protocols #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(common): Add ESP DNS module with support for UDP, DoT, and DoH protocols #781
Conversation
f575341
to
78cf2bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful component, generally LGTM, just left a few nitpicks. Nice work!
components/esp_dns/examples/esp_dns_basic/main/esp_dns_example.c
Outdated
Show resolved
Hide resolved
components/esp_dns/examples/esp_dns_basic/main/esp_dns_example.c
Outdated
Show resolved
Hide resolved
5174737
to
c23e87f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a few nitpicks.
Assume you're not planning to publish it yet, just merging to master, correct?
… protocols This commit introduces a custom DNS module for ESP32, enabling DNS resolution capabilities over various protocols including UDP, TCP, DNS over TLS (DoT), and DNS over HTTPS (DoH). The module includes initialization and cleanup functionalities, along with protocol-specific implementations for each DNS type.
c23e87f
to
4017664
Compare
This commit introduces a custom DNS module for ESP32, enabling DNS resolution capabilities over various protocols including traditional UDP, TCP, DNS over TLS (DoT), and DNS over HTTPS (DoH). The module includes initialization, cleanup, and error handling functionalities, along with protocol-specific implementations for each DNS type.
Description
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: