Skip to content

feat(common): Add ESP DNS module with support for UDP, DoT, and DoH protocols #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

espressif-abhikroy
Copy link
Collaborator

@espressif-abhikroy espressif-abhikroy commented Mar 14, 2025

This commit introduces a custom DNS module for ESP32, enabling DNS resolution capabilities over various protocols including traditional UDP, TCP, DNS over TLS (DoT), and DNS over HTTPS (DoH). The module includes initialization, cleanup, and error handling functionalities, along with protocol-specific implementations for each DNS type.

Description

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@espressif-abhikroy espressif-abhikroy self-assigned this Mar 14, 2025
@espressif-abhikroy espressif-abhikroy force-pushed the component/esp_dns branch 6 times, most recently from f575341 to 78cf2bc Compare March 21, 2025 12:58
@espressif-abhikroy espressif-abhikroy marked this pull request as ready for review March 21, 2025 12:59
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful component, generally LGTM, just left a few nitpicks. Nice work!

@espressif-abhikroy espressif-abhikroy force-pushed the component/esp_dns branch 3 times, most recently from 5174737 to c23e87f Compare April 4, 2025 10:01
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a few nitpicks.

Assume you're not planning to publish it yet, just merging to master, correct?

… protocols

This commit introduces a custom DNS module for ESP32, enabling DNS resolution capabilities
over various protocols including UDP, TCP, DNS over TLS (DoT), and DNS over HTTPS (DoH).
The module includes initialization and cleanup functionalities, along with
protocol-specific implementations for each DNS type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants